feat(skill-manager): prevent removed external skills from being redis…#1242
Open
gastoner wants to merge 1 commit intokortex-hub:mainfrom
Open
feat(skill-manager): prevent removed external skills from being redis…#1242gastoner wants to merge 1 commit intokortex-hub:mainfrom
gastoner wants to merge 1 commit intokortex-hub:mainfrom
Conversation
…covered on re-init Adds a `SKILL_REMOVED` config key and a `removedNames` set to SkillManager. When an external (non-managed) skill is unregistered, its name is stored in `skills.removed` and persisted to config. Discovery skips any skill whose name appears in that set, preventing it from reappearing after a restart or folder re-registration. Also narrows `isManagedSkill` to only check the Kortex skills directory (not all registered folders), so extension-registered skills are always treated as external and correctly tracked as removed rather than deleted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>
📝 WalkthroughWalkthroughThis PR introduces tracking for removed/unregistered external skills to prevent their rediscovery. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SkillManager
participant Config
participant Discovery
User->>SkillManager: unregisterSkill('external-skill')
Note over SkillManager: External skill detected
SkillManager->>SkillManager: Add to removedNames Set
SkillManager->>Config: saveSkillsToConfig()<br/>persist SKILL_REMOVED
Config->>Config: Update config with removed names
User->>SkillManager: init() / rediscoverSkills()
SkillManager->>Discovery: processDiscoveredPaths()
Discovery->>Discovery: Parse skill metadata
Discovery->>SkillManager: Check removedNames Set
alt Skill in removedNames
SkillManager->>SkillManager: Skip skill
else Skill not removed
SkillManager->>SkillManager: Include skill
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/main/src/plugin/skill/skill-manager.spec.ts (1)
719-721: Consider using regular string literals for simple YAML test data.Static analysis flags these template literals as having no interpolation. While template literals work fine here, regular strings with explicit
\nwould be consistent with the static analysis rules. This is a minor stylistic preference.Example fix for one instance
- [{ name: 'extra-skill', content: `---\nname: extra-skill\ndescription: An extra skill\n---\n# Extra\n` }], + [{ name: 'extra-skill', content: '---\nname: extra-skill\ndescription: An extra skill\n---\n# Extra\n' }],Also applies to: 740-742, 802-804, 872-876, 964-966
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/main/src/plugin/skill/skill-manager.spec.ts` around lines 719 - 721, Replace the template literals used for simple YAML test data with regular string literals: change occurrences where objects like { name: 'extra-skill', content: `---\nname: extra-skill\ndescription: An extra skill\n---\n# Extra\n` } (and the similar literals at the other noted spots) to use plain quoted strings with explicit \n sequences (e.g., '---\nname: extra-skill\n...') so static analysis no longer flags them as unnecessary template literals; update each instance that sets the content property in the test data (the objects passed alongside EXTRA_DIR and similar test fixtures) to use regular string literals.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/main/src/plugin/skill/skill-manager.spec.ts`:
- Around line 719-721: Replace the template literals used for simple YAML test
data with regular string literals: change occurrences where objects like { name:
'extra-skill', content: `---\nname: extra-skill\ndescription: An extra
skill\n---\n# Extra\n` } (and the similar literals at the other noted spots) to
use plain quoted strings with explicit \n sequences (e.g., '---\nname:
extra-skill\n...') so static analysis no longer flags them as unnecessary
template literals; update each instance that sets the content property in the
test data (the objects passed alongside EXTRA_DIR and similar test fixtures) to
use regular string literals.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d892c35d-6677-44ad-b3e8-a471041e45fc
📒 Files selected for processing (3)
packages/api/src/skill/skill-info.tspackages/main/src/plugin/skill/skill-manager.spec.tspackages/main/src/plugin/skill/skill-manager.ts
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…covered on re-init
Adds a
SKILL_REMOVEDconfig key and aremovedNamesset to SkillManager. When an external (non-managed) skill is unregistered, its name is stored inskills.removedand persisted to config. Discovery skips any skill whose name appears in that set, preventing it from reappearing after a restart or folder re-registration.Also narrows
isManagedSkillto only check the Kortex skills directory (not all registered folders), so extension-registered skills are always treated as external and correctly tracked as removed rather than deleted.